chore: extract ecosystem enum [OSM-2231]

Adding new ecosystem support in small steps because the diff for the
original work is too massive. First baby step = introducing the
Ecosystem enum and extracting the file matching logic to it.

core/src/main/java/io/snyk/plugins/artifactory/scanner/Ecosystem.java

@@ -0,0 +1,39 @@
+package io.snyk.plugins.artifactory.scanner;
+
+import io.snyk.plugins.artifactory.configuration.PluginConfiguration;
+
+import java.util.Optional;
+
+public enum Ecosystem {
+
+  MAVEN(PluginConfiguration.SCANNER_PACKAGE_TYPE_MAVEN),
+  NPM(PluginConfiguration.SCANNER_PACKAGE_TYPE_NPM),
+  PYPI(PluginConfiguration.SCANNER_PACKAGE_TYPE_PYPI),
+  ;
+
+  private final PluginConfiguration configProperty;
+
+  Ecosystem(PluginConfiguration configProperty) {
+    this.configProperty = configProperty;
+  }
+
+  public PluginConfiguration getConfigProperty() {
+    return configProperty;
+  }
+
+  static Optional<Ecosystem> fromPackagePath(String path) {
+    if (path.endsWith(".jar")) {
+      return Optional.of(MAVEN);
+    }
+
+    if (path.endsWith(".tgz")) {
+      return Optional.of(NPM);
+    }
+
+    if (path.endsWith(".whl") || path.endsWith(".tar.gz") || path.endsWith(".zip") || path.endsWith(".egg")) {
+      return Optional.of(PYPI);
+    }
+
+    return Optional.empty();
+  }
+}

core/src/main/java/io/snyk/plugins/artifactory/scanner/ScannerModule.java

@@ -20,7 +20,6 @@
 import java.util.Optional;
 
 import static io.snyk.plugins.artifactory.configuration.ArtifactProperty.*;
-import static io.snyk.plugins.artifactory.configuration.PluginConfiguration.*;
 import static io.snyk.sdk.util.Predicates.distinctByKey;
 import static java.lang.String.format;
 import static java.util.Objects.requireNonNull;
@@ -58,28 +57,21 @@ public void scanArtifact(@Nonnull RepoPath repoPath) {
   }
 
   protected PackageScanner getScannerForPackageType(String path) {
-    if (path.endsWith(".jar")) {
-      if (configurationModule.getPropertyOrDefault(SCANNER_PACKAGE_TYPE_MAVEN).equals("true")) {
-        return mavenScanner;
-      }
-      throw new CannotScanException(format("Plugin Property \"%s\" is not \"true\".", SCANNER_PACKAGE_TYPE_MAVEN.propertyKey()));
+    Ecosystem ecosystem = Ecosystem.fromPackagePath(path).orElseThrow(() -> new CannotScanException("Artifact is not supported."));
+    if(!configurationModule.getPropertyOrDefault(ecosystem.getConfigProperty()).equals("true")) {
+      throw new CannotScanException(format("Plugin Property \"%s\" is not \"true\".", ecosystem.getConfigProperty().propertyKey()));
     }
 
-    if (path.endsWith(".tgz")) {
-      if (configurationModule.getPropertyOrDefault(SCANNER_PACKAGE_TYPE_NPM).equals("true")) {
+    switch (ecosystem) {
+      case MAVEN:
+        return mavenScanner;
+      case NPM:
         return npmScanner;
-      }
-      throw new CannotScanException(format("Plugin Property \"%s\" is not \"true\".", SCANNER_PACKAGE_TYPE_NPM.propertyKey()));
-    }
-
-    if (path.endsWith(".whl") || path.endsWith(".tar.gz") || path.endsWith(".zip") || path.endsWith(".egg")) {
-      if (configurationModule.getPropertyOrDefault(SCANNER_PACKAGE_TYPE_PYPI).equals("true")) {
+      case PYPI:
         return pythonScanner;
-      }
-      throw new CannotScanException(format("Plugin Property \"%s\" is not \"true\".", SCANNER_PACKAGE_TYPE_PYPI.propertyKey()));
+      default:
+        throw new IllegalStateException("Unsupported ecosystem: " + ecosystem.name());
     }
-
-    throw new CannotScanException("Artifact is not supported.");
   }
 
   protected void updateProperties(RepoPath repoPath, TestResult testResult) {

core/src/test/java/io/snyk/plugins/artifactory/scanner/EcosystemTest.java

@@ -0,0 +1,19 @@
+package io.snyk.plugins.artifactory.scanner;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class EcosystemTest {
+
+  @Test
+  void testGetScannerForPackageType() {
+    assertEquals(Ecosystem.MAVEN, Ecosystem.fromPackagePath("myArtifact.jar").orElse(null));
+    assertEquals(Ecosystem.NPM, Ecosystem.fromPackagePath("myArtifact.tgz").orElse(null));
+    assertEquals(Ecosystem.PYPI, Ecosystem.fromPackagePath("myArtifact.whl").orElse(null));
+    assertEquals(Ecosystem.PYPI, Ecosystem.fromPackagePath("myArtifact.tar.gz").orElse(null));
+    assertEquals(Ecosystem.PYPI, Ecosystem.fromPackagePath("myArtifact.zip").orElse(null));
+    assertEquals(Ecosystem.PYPI, Ecosystem.fromPackagePath("myArtifact.egg").orElse(null));
+    assertNull(Ecosystem.fromPackagePath("file.txt").orElse(null));
+  }
+}

core/src/test/java/io/snyk/plugins/artifactory/scanner/ScannerModuleTest.java

@@ -29,29 +29,6 @@
 
 public class ScannerModuleTest {
 
-  @Test
-  void testGetScannerForPackageType() {
-    Properties properties = new Properties();
-    properties.put(SCANNER_PACKAGE_TYPE_MAVEN.propertyKey(), "true");
-    properties.put(SCANNER_PACKAGE_TYPE_NPM.propertyKey(), "true");
-    properties.put(SCANNER_PACKAGE_TYPE_PYPI.propertyKey(), "true");
-
-    ConfigurationModule configurationModule = new ConfigurationModule(properties);
-
-    ScannerModule sm = new ScannerModule(
-      configurationModule,
-      mock(Repositories.class),
-      mock(SnykClient.class));
-
-    assertEquals(MavenScanner.class, sm.getScannerForPackageType("myArtifact.jar").getClass());
-    assertEquals(NpmScanner.class, sm.getScannerForPackageType("myArtifact.tgz").getClass());
-    assertEquals(PythonScanner.class, sm.getScannerForPackageType("myArtifact.whl").getClass());
-    assertEquals(PythonScanner.class, sm.getScannerForPackageType("myArtifact.tar.gz").getClass());
-    assertEquals(PythonScanner.class, sm.getScannerForPackageType("myArtifact.zip").getClass());
-    assertEquals(PythonScanner.class, sm.getScannerForPackageType("myArtifact.egg").getClass());
-    assertThrows(CannotScanException.class, () -> sm.getScannerForPackageType("unknown"));
-  }
-
   @Test
   void testGetScannerForPackageType_cannotScanPathsWithDisabledScanners() {
     Properties properties = new Properties();