feat: switch first lifecycle hook to afterCreate #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching the hook which gates artifact downloads from `afterRemoteDownload` to `afterCreate`. For some ecosystems, e.g. Python and Cocoapods, properties would fail to write during the `afterRemoteDownload`. This would manifest with the following error message in Artifactory logs: ``` Cannot add properties for <repository path> Item not found. ``` The `afterCreate` hook is also attached to initial downloads of artifacts, and properties are successfully created in this context across all ecosystems supported by this plugin.
MarcusArdelean
approved these changes
Nov 26, 2024
jacek-rzrz
deleted the
feat/switch-first-lifecycle-hook-to-afterCreate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching the hook which gates artifact downloads from
afterRemoteDownloadtoafterCreate.For some ecosystems, e.g. Python and Cocoapods, properties would fail to write during the
afterRemoteDownload. This would manifest with the following error message in Artifactory logs:The
afterCreatehook is also attached to initial downloads of artifacts, and properties are successfully created in this context across all ecosystems supported by this plugin.