Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are tests working? 😬 #92

Merged
merged 2 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,4 @@ Wait until the Docker has loaded, it can take a while. Check the progress with `

You'll have a ton of trouble if you default to building your Docker images as `linux/amd64`. At least I had. Ensure you
do not have a env variable like `DOCKER_DEFAULT_PLATFORM=linux/amd64` enabled when pulling and/or running the image.

Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ void shouldTestPipPackage() throws Exception {
TestResult result = scanner.scan(fileLayoutInfo, repoPath);
assertFalse(result.success);
assertEquals(1, result.dependencyCount);
assertEquals(3, result.issues.vulnerabilities.size());
assertEquals(5, result.issues.vulnerabilities.size());
assertEquals("pip", result.packageManager);
assertEquals(org, result.organisation.id);
assertEquals("https://snyk.io/vuln/pip%3Aurllib3%401.25.7", result.packageDetailsURL);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ void testScanPythonItem_withVulns() throws Exception {
TestResult tr = testResultCaptor.getValue();
assertFalse(tr.success);
assertEquals(1, tr.dependencyCount);
assertEquals(3, tr.issues.vulnerabilities.size());
assertEquals(5, tr.issues.vulnerabilities.size());
assertEquals("pip", tr.packageManager);
assertEquals(testSetup.org, tr.organisation.id);

Expand Down
Loading