refactor: use api.snyk.io as default url #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlourenc
changed the title
`snyk.io/api` is the legacy and deprecated way to access Snyk APIs. Let's default to `api.snyk.io` instead.
jlourenc
force-pushed
the
refactor/snyk-api-url
branch
from
a4a0768 to
e6ca91e
Compare
jlourenc
commented
Jul 17, 2024
| @@ -41,7 +41,7 @@ void shouldTestPipPackage() throws Exception { | |||
| TestResult result = scanner.scan(fileLayoutInfo, repoPath); | |||
| assertFalse(result.success); | |||
| assertEquals(1, result.dependencyCount); | |||
| assertEquals(5, result.issues.vulnerabilities.size()); | |||
| assertEquals(6, result.issues.vulnerabilities.size()); | |||
There was a problem hiding this comment.
Had to bump this to 6 as this seems to use real data and number of vulns has increased.
dotkas
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snyk.io/apiis the legacy and deprecated way to access Snyk APIs. Let's default toapi.snyk.ioinstead.