fix: debug logs causing CLI to quit unexpectedly [CLI-638] #5682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-luong
force-pushed
the
fix/CLI-638_truncateLogLine
branch
from
691796c to
a784077
Compare
j-luong
force-pushed
the
fix/CLI-638_truncateLogLine
branch
from
a784077 to
0318b71
Compare
|
|
||
| // Upper limit of string length that should be allowed for output to stdrr || stdout. | ||
| // Use when outputting strings of unknown length. e.g. response payloads | ||
| export const MAX_STRING_LENGTH = 50000; |
There was a problem hiding this comment.
💭 How did we end up at 50,000? Did the logs we have get cut above this value?
There was a problem hiding this comment.
When looking at CLI logs, the CLI was unexpectedly quitting on debug logs when the character length was ~70-75k. I chose 50k as a "safe" upper limit
sandor-trombitas
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
This PR should set an upper limit on the length of some logs outputted by the
debuglib. In particular, log a log that outputs an full api response which can lead to the CLI quitting unexpectedly.Where should the reviewer start?
How should this be manually tested?