Merge pull request #1237 from cloudskiff/fix_version_check_test

Make version check test more dynamic
snyk · Nov 29, 2021 · cbc6fd7 · cbc6fd7
2 parents ca60550 + 4b3778a
commit cbc6fd7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 18 deletions.
diff --git a/pkg/cmd/driftctl_test.go b/pkg/cmd/driftctl_test.go
@@ -41,23 +41,6 @@ func TestDriftctlCmd_Help(t *testing.T) {
 	}
 }
 
-func TestDriftctlCmd_Version(t *testing.T) {
-	cmd := NewDriftctlCmd(mocks.MockBuild{})
-
-	output, err := test.Execute(&cmd.Command, "version")
-	if output == "" {
-		t.Errorf("Unexpected output: %v", output)
-	}
-	if err != nil {
-		t.Errorf("Unexpected error: %v", err)
-	}
-
-	expected := "dev-dev\n"
-	if output != expected {
-		t.Errorf("Expected %v, got %v", expected, output)
-	}
-}
-
 func TestDriftctlCmd_Completion(t *testing.T) {
 	cmd := NewDriftctlCmd(mocks.MockBuild{})
 

diff --git a/pkg/cmd/version_test.go b/pkg/cmd/version_test.go
@@ -1,8 +1,10 @@
 package cmd
 
 import (
+	"fmt"
 	"testing"
 
+	"github.com/cloudskiff/driftctl/pkg/version"
 	"github.com/cloudskiff/driftctl/test"
 
 	"github.com/spf13/cobra"
@@ -20,7 +22,7 @@ func TestVersionCmd(t *testing.T) {
 		t.Errorf("Unexpected error: %v", err)
 	}
 
-	expected := "dev-dev\n"
+	expected := fmt.Sprintf("%s\n", version.Current())
 	if output != expected {
 		t.Errorf("Expected %v, got %v", expected, output)
 	}