Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: do not show the snyk-report-tab on build results that do not contain the snyk task #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhyskoedijk
Copy link

@rhyskoedijk rhyskoedijk commented Nov 7, 2024

Currently the "Snyk Report" tab shows on all build results, even if the build pipeline does not actually use the Snyk task. If the task is never run, the tab renders nothing and just clutters the build results.

This change restricts the tab so that it only show for builds that actually ran the Snyk task.

image
^ this build pipeline does not contain the Snyk task, but it shows anyway.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024

CLA assistant check
All committers have signed the CLA.

@rhyskoedijk rhyskoedijk marked this pull request as ready for review November 7, 2024 09:47
@rhyskoedijk rhyskoedijk requested a review from a team as a code owner November 7, 2024 09:47
@rhyskoedijk rhyskoedijk force-pushed the feature/define-supports-tasks branch from b9bc066 to c688d1c Compare November 9, 2024 04:35
@rhyskoedijk
Copy link
Author

@j-luong any chance this could be approved? thanks

@rhyskoedijk
Copy link
Author

@thisislawatts @schottsfired, any chance of considering this change to hide the Snyk report tab in pipelines that do not contain the Snyk task?

@schottsfired
Copy link
Collaborator

Thanks so much for your contribution @rhyskoedijk! I wasn't able to find official docs for this, but it looks good to me based on the following:
https://github.com/microsoft/vsts-extension-samples/blob/da897c8ff271a77811f7a5e6eeb791bd01e1fe08/build-results-enhancer/README.md?plain=1#L23-L24

WDYT @thisislawatts ?

@rhyskoedijk
Copy link
Author

@schottsfired yes unfortunately Microsoft haven't documented the list of properties; it's even missing from the vss-extension.json schema file. However, as you mentioned, there are many examples of this throughout the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants