Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add java application files collection #636

Closed
wants to merge 1 commit into from

Conversation

davidgonor1408
Copy link
Contributor

@davidgonor1408 davidgonor1408 commented Dec 31, 2024

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?
https://snyksec.atlassian.net/wiki/x/3oA6o

Where should the reviewer start?
Following the logical flow starting from lib/analyzer/static-analyzer.ts will be easier to follow.

How should this be manually tested?
Using the Docker registry agent(DRA) (https://github.com/snyk/docker-registry-agent) update the installed Snyk docker plugin version (in the package.json) to be based on the current branch:
"snyk-docker-plugin": "github:snyk/snyk-docker-plugin#collect_application_files".
Run npm install.
Run the DRA locally and from a different terminal execute the following command:

curl --location 'http://localhost:17500/scan' \
--header 'snyk-source-credentials: <<CREDENTIALS_FOR_CR>>' \
--header 'Content-Type: application/json' \
--data '{
    "target": {
        "name": "<<IMAGE_ON_CR>>"
    },
    "options": {
        "appScan": true,
        "collectApplicationFiles": true
    },
    "callbacks": {
        "resultUrl": "<<RESULT_URL>>",                                   
        "doneUrl": "<<DONE_URL>>",
        "token": "00000000-0000-0000-0000-000000000000"
    }   
}'

The expected output of the given RESULT_URL endpoint should contain the fact type "applicationFiles" as part of the data.
The image should be running Java code.

What are the relevant tickets?
https://snyksec.atlassian.net/browse/RNTM-744
https://snyksec.atlassian.net/browse/RNTM-745

@davidgonor1408 davidgonor1408 requested a review from nozik December 31, 2024 10:42
@davidgonor1408 davidgonor1408 self-assigned this Dec 31, 2024
@davidgonor1408 davidgonor1408 requested a review from a team as a code owner December 31, 2024 10:42
@prsnca prsnca closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants