-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional metadata from manifest file #638
Open
nata7che
wants to merge
5
commits into
main
Choose a base branch
from
RMTN-852_additional_metadata_from_manifest_file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+288
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: extract repoUrl from nodejs manifest
nata7che
force-pushed
the
RMTN-852_additional_metadata_from_manifest_file
branch
from
January 8, 2025 07:03
c48d7ad
to
99d8b79
Compare
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
reviewed
Jan 8, 2025
nozik
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When collecting ApplicationFiles, this PR adds additional data for manifest files in nodejs (e.g.
package.json
).This PR is an addition to #629.
Where should the reviewer start?
Following the logical flow starting from
lib/analyzer/static-analyzer.ts
will be easier to follow.How should this be manually tested?
Using the Docker registry agent(DRA) (https://github.com/snyk/docker-registry-agent) update the installed Snyk docker plugin version (in the package.json) to be based on the current branch:
"snyk-docker-plugin": "github:snyk/snyk-docker-plugin#collect_application_files"
.Run
npm install
.Run the DRA locally and from a different terminal execute the following command:
The expected output of the given RESULT_URL endpoint should contain the fact type "applicationFiles" as part of the data.
Each manifest file should include the
type: 'manifest'
andmetadata
with the extractedmoduleName
.The image should be NodeJS.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/RNTM-744
https://snyksec.atlassian.net/browse/RNTM-852