Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes monaco editor dependencies #1434

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Fixes monaco editor dependencies #1434

merged 1 commit into from
Jul 24, 2022

Conversation

nezhar
Copy link
Collaborator

@nezhar nezhar commented Jul 24, 2022

Fixes dependency issues by using overrides as described in atularen/ngx-monaco-editor#259

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #1434 (850fdcd) into master (21e0fc0) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   43.12%   42.87%   -0.25%     
==========================================
  Files          58       58              
  Lines         807      807              
  Branches       55       55              
==========================================
- Hits          348      346       -2     
- Misses        451      453       +2     
  Partials        8        8              
Impacted Files Coverage Δ
src/environments/environment.ts 100.00% <ø> (ø)
...s/team-member-modal/team-member-modal.component.ts 36.11% <0.00%> (-5.56%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@nezhar nezhar merged commit dcd3722 into master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants