Fixing case misalignment between Linux and Windows sysmon event ID field name #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed incorrect case on system.eventId to system.eventID
fixed incorrect case on system.eventId to system.eventID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears you are basing your Sysmon for Linux decoded field names off of the Windows Sysmon equivalent field names, which I think is a great idea.
I did note one inconsistency, though, in that Windows Sysmon's event ID field name ends with "system.eventID" while you are decoding Linux Sysmon event ID fields under the name "system.eventId" (lowercase final letter). This PR is my proposal to bring that field into case alignment with the Windows side.
Thanks so much for your valuable contributions to the Wazuh open source community!