base nix on ubuntu, no nix-shell for prod image, prod-image 1.47GB #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdietze
changed the title
JohannesNakayama
approved these changes
Jun 5, 2024
johnwarden
approved these changes
Jun 6, 2024
…ge-fdietze-2024-06-04
mergify
bot
deleted the
base-nix-on-ubuntu-no-nix-shell-for-prod-image-fdietze-2024-06-04
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the production docker image doen't use the nix-shell anymore. We only need the packages without env variables, since nothing needs to be compiled. We also base it on ubuntu, because it is a smaller base system (~25MB) than the nix image was (~200MB). nix garbage collection helps to reduce the nix-store even more.
This brings the production docker-image down from 2.01GB to 1.47GB (save 0.54GB).
No more
/bin/shis needed in the production shell, since we're not using a nix-shell anymore.