embedded tweet refactoring jnakayama 2024 10 10 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JohannesNakayama
commented
Oct 10, 2024
JohannesNakayama
commented
- embedded tweet refactoring
- display embedded tweet on artefact page
johnwarden
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
Looks great. Some small comments:
- Small issue with error-handling logic. For example, if you submit a URL that looks valid, but with a non-existent ID, it just says "loading" instead of "Tweet not found"
- On the quote/$quoteId page, the embedded Tweet is shown above the tabs with the extracted claims etc. You have to scroll down to see anything else. I think the "Retrieved..." text and the tabs should actually go above the embedded tweet.
mergify
bot
deleted the
embedded-tweet-refactoring-jnakayama-2024-10-10
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.