Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] [Frontend] Generate a negative reputation proof when checking in #511

Merged

Conversation

Xiawpohr
Copy link
Collaborator

Summary

When user's reputation is negative, generate a negative reputation proof, put this proof in authorization header of check-in API.

Linked Issue

close #508

@Xiawpohr Xiawpohr self-assigned this Sep 16, 2024
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, just me playing in the PR still cannot get negative reputation even I was being reported successfully, so hard to check if the checkin functions.

@Xiawpohr
Copy link
Collaborator Author

The code looks good to me, just me playing in the PR still cannot get negative reputation even I was being reported successfully, so hard to check if the checkin functions.

Perhaps we should merge PR#512 first before this one.

@Xiawpohr Xiawpohr force-pushed the fix/generate-negative-reputation-proof-when-checking-in branch from b833a7d to 4fed2c7 Compare September 18, 2024 12:42
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I do get both positive and negative reputation
  2. I do trigger the daily checkin to pop up if I had negative reputation
  3. I clicked on daily checked in, do have +1 to my reputation
  4. I cannot do anything when I have negative reputation

however, some issues might relate to this PR, open an issue here: #516

if you think it's not related, I would approve this PR and we could deal with the issue in another PR.

@Xiawpohr
Copy link
Collaborator Author

@kittybest I think the issue #516 is not in the scope of this PR. We can deal with it in another PR.

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Xiawpohr Xiawpohr merged commit d2823d9 into main Sep 19, 2024
5 of 6 checks passed
@Xiawpohr Xiawpohr deleted the fix/generate-negative-reputation-proof-when-checking-in branch September 19, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(frontend): fail to claim check in rep
2 participants