-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] [Frontend] Generate a negative reputation proof when checking in #511
[Fix] [Frontend] Generate a negative reputation proof when checking in #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, just me playing in the PR still cannot get negative reputation even I was being reported successfully, so hard to check if the checkin functions.
Perhaps we should merge PR#512 first before this one. |
b833a7d
to
4fed2c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I do get both positive and negative reputation
- I do trigger the daily checkin to pop up if I had negative reputation
- I clicked on daily checked in, do have +1 to my reputation
- I cannot do anything when I have negative reputation
however, some issues might relate to this PR, open an issue here: #516
if you think it's not related, I would approve this PR and we could deal with the issue in another PR.
@kittybest I think the issue #516 is not in the scope of this PR. We can deal with it in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Summary
When user's reputation is negative, generate a negative reputation proof, put this proof in authorization header of check-in API.
Linked Issue
close #508