Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unirep version (2.1.5-alpha-1) #519

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: fix unirep version (2.1.5-alpha-1) #519

merged 1 commit into from
Sep 30, 2024

Conversation

vivianjeng
Copy link
Contributor

Please follow the guidelines in Contribution.md first, then start to create your pull request here.

Summary

State tree leaf id is fixed, there should not be duplicated leaf in indexed db
Fix InvalidHistoryTreeRoot and InvalidStateTreeRoot

Linked Issue

If your PR addresses a particular issue, provide its link here.

Details

Any implementation detail worth pointing out, if any.

Impacted Areas

List the files or modules that this PR will change.

Tests

Mention all types of tests (unit, integration, performance, etc.) that you've carried out and if any specific environment or configuration is needed to run them.

Possible Impacts

Describe any existing features that might be affected by this change, or any potential backward compatibility issues, if any.

Visual Materials

If your changes have UI effects, consider attaching screenshots or videos to demonstrate them.

Verification Steps

Provide a step-by-step guide for others to reproduce your results and verify your changes.

Todo

Break down the progress of the PR for everyone to see what else you intend to include in this PR.

  • Draft implementation for function
  • Unit tests for function

Checklist

  • All new and existing tests pass
  • I have updated the documentation (if applicable)
  • My changes do not introduce new security vulnerabilities

@github-actions github-actions bot added documentation Improvements or additions to documentation duplicate This issue or pull request already exists feature new feature test test improvements contracts frontend relay and removed documentation Improvements or additions to documentation duplicate This issue or pull request already exists feature new feature test test improvements labels Sep 25, 2024
Copy link
Collaborator

@Xiawpohr Xiawpohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test successfully these features including post, comment, vote, report, adjudicate, and check-in.

@kittybest
Copy link
Collaborator

kittybest commented Sep 30, 2024

seems like there are still some problems with displaying the posts (as we mentioned before, user1 cannot see user2's new post after epoch 1, also user2 cannot see user1's new post, they can only see the post by others only from previous epochs)

BUT! this is not the issue this PR should tackle with, so just leave it there.
image
by user 2
image
by user 1

@kittybest
Copy link
Collaborator

also another issue (should open another issue ticket)
image
the thumb up amount should be updated

@kittybest
Copy link
Collaborator

& this issue again:
image
I should have 1 reputation, but only got 0

@kittybest
Copy link
Collaborator

image image

another issue: if the user is a negative user, then the adjudicate popup shouldn't be shown on his/her page.

@Xiawpohr
Copy link
Collaborator

& this issue again: image I should have 1 reputation, but only got 0

I need to the reproducible steps to confirm this issue in my local environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants