[Test] Login Frontend #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/Add-frontend-test # Conflicts: # packages/frontend/.gitignore # packages/frontend/package.json # packages/frontend/src/hooks/useSignupWithWallet.ts # yarn.lock
…ture/Add-frontend-test # Conflicts: # package-lock.json # package.json # yarn.lock
github-actions
bot
added
documentation
badukwei
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Should we create tests for the functions in the context and make it safer?
There was a problem hiding this comment.
Yes, we need add more test about dom and state change
Xiawpohr
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completed the setup of the Testing Library and merged the Playwright settings branch. Added several DOM test cases to enhance our testing coverage.
Linked Issue
#36
Details
Impacted Areas
Tests
Possible Impacts
The changes made primarily focus on testing, so there shouldn't be any impact on the actual functionality of the application. However, there could be potential overlaps or conflicts with other testing tools or configurations, if any.
Verification Steps
yarn test,yarn test:e2e,yarn test:dom.Todo
Checklist