feat: add close button to adjudicate notification #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
Xiawpohr
reviewed
Nov 1, 2024
...frontend/src/features/reporting/components/AdjudicateNotification/AdjudicateNotification.tsx
Outdated
Show resolved
Hide resolved
...frontend/src/features/reporting/components/AdjudicateNotification/AdjudicateNotification.tsx
Outdated
Show resolved
Hide resolved
...frontend/src/features/reporting/components/AdjudicateNotification/AdjudicateNotification.tsx
Outdated
Show resolved
Hide resolved
...frontend/src/features/reporting/components/AdjudicateNotification/AdjudicateNotification.tsx
Outdated
Show resolved
Hide resolved
...frontend/src/features/reporting/components/AdjudicateNotification/AdjudicateNotification.tsx
Outdated
Show resolved
Hide resolved
| } | ||
| }, [activeAdjudication]) | ||
|
|
||
| const closeAdjudicate = () => { | ||
| toggle(false) | ||
| } |
There was a problem hiding this comment.
The button should be visible again when closing adjudication dialog.
There was a problem hiding this comment.
The button's visibility depends on buttonVisible, so it should be visible again when closing adjudication dialog now. Please let me know if i misunderstood.
There was a problem hiding this comment.
The floating button becomes invisible if I close adjudication dialog. You should make it visible again.
Screen.Recording.2024-11-05.at.12.51.20.PM.mov
There was a problem hiding this comment.
Got it ! Solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add close button to adjudicate notification
Linked Issue
close #559
Details
Impacted Areas
packages/frontend/src/features/reporting/components/AdjudicateNotification
Verification Steps
close button of notification
confirmation
4. close if pressed confirmed(also closes the notification)
5. jump to adjudication if pressed cancel(also closes the notification)
6. close if pressed close button(does not closes the notification)