Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve formatting of floats in edge cases #65

Closed
wants to merge 1 commit into from

Conversation

rafzi
Copy link

@rafzi rafzi commented Nov 14, 2023

some floats would be written as scientific notation using the default representer. this will cause yaml to insert a !!float tag which is not recognized by unity.

for example: 0.000000001 --> !!float 1e-9

@sp-ricard-valverde
Copy link
Collaborator

I'll be closing this PR according to comment #66 (comment).

I'll prepare a new major release in the following weeks tackling the float formatting problem from it's root(treating them as strings when serialized, then let the user decide if they want to convert them to float when manipulating the yaml attributes).

Thank you for you're contribution though, it was much appreciated !

@rafzi
Copy link
Author

rafzi commented Nov 15, 2023

sounds great thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants