tests #7
Closed
tests #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing for now other stuff seems broken |
|
My general policy is to drop support for EOL Rubies. Ruby 3.1+ fully supports the fiber scheduler, so I was eager to drop support for 3.0 when it became EOL. As there will no longer be security updates, I also advise you to move to 3.3.1 or at least 3.1+. |
|
Ah yeah what I meant was I was trying them out anyway, but if we drop support for 3.1, that does make everything easier. I made a new PR here with most of the stuff fixed #8. I'm not entirely sure how to deal with TruffleRuby or JRuby. |
|
Don't worry about JRuby and TruffleRuby, they are just there for tracking compatibility. I think we will start to see those platforms support the fiber scheduler within the next year or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to run down a few versions of ruby and found that at 3.0 it gave me this error:
Fetching gem metadata from https://rubygems.org/........
fiber-local-1.1.0 requires ruby version >= 3.1, which is incompatible with the current version, ruby
3.0.7p220
This tells me that we are no only 3.1 and above? Or perhaps we need to support a lower version of Ruby by downgrading fiber-local? I'm not sure how to go about this.
Types of Changes
Contribution