Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix tests #8

Merged
merged 4 commits into from
May 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ jobs:
- macos

ruby:
- "2.7"
- "3.0"
- "3.1"
- "3.2"
- "3.3"

experimental: [false]

Expand Down
7 changes: 3 additions & 4 deletions falcon-capybara.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,14 @@ Gem::Specification.new do |spec|

spec.files = Dir.glob(['{lib}/**/*', '*.md'], File::FNM_DOTMATCH, base: __dir__)

spec.required_ruby_version = ">= 2.5"
spec.required_ruby_version = ">= 3.1"

spec.add_dependency "capybara", "~> 3.37"
spec.add_dependency "falcon", "~> 0.34"
spec.add_dependency "falcon"
spec.add_dependency "selenium-webdriver"

spec.add_development_dependency "bake"
spec.add_development_dependency "bundler"
spec.add_development_dependency "covered"
spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "webdrivers", "~> 4.0"
spec.add_development_dependency "rspec"
end
23 changes: 13 additions & 10 deletions lib/falcon/capybara/drivers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,24 @@
# @name selenium_chrome_https
# @attribute [Block]
Capybara.register_driver :selenium_chrome_https do |app|
require 'selenium/webdriver'

Capybara.drivers[:selenium_chrome].call(app).tap do |driver|
driver.options[:capabilities].args << '--allow-insecure-localhost'
end
chrome_options = Selenium::WebDriver::Chrome::Options.new
chrome_options.add_argument('--allow-insecure-localhost')
chrome_options.add_argument('--ignore-certificate-errors')
Capybara::Selenium::Driver.new(app,
browser: :chrome,
options: chrome_options)
end

# A headless selenium driver for chrome which allows insecure localhost https protocol.
# @scope Falcon Capybara Drivers
# @name selenium_chrome_headless_https
# @attribute [Block]
Capybara.register_driver :selenium_chrome_headless_https do |app|
require 'selenium/webdriver'

Capybara.drivers[:selenium_chrome_headless].call(app).tap do |driver|
driver.options[:capabilities].args << '--allow-insecure-localhost'
end
chrome_options = Selenium::WebDriver::Chrome::Options.new
chrome_options.add_argument('--allow-insecure-localhost')
chrome_options.add_argument('--ignore-certificate-errors')
chrome_options.add_argument('--headless=true')
Capybara::Selenium::Driver.new(app,
browser: :chrome,
options: chrome_options)
end
1 change: 0 additions & 1 deletion lib/falcon/capybara/wrapper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

require 'async'
require 'falcon/endpoint'
require 'async/io/notification'

module Falcon
module Capybara
Expand Down
1 change: 0 additions & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

require "falcon/capybara"

require "webdrivers"
require "selenium/webdriver"

require "capybara/rspec"
Expand Down
Loading