Breakout reading of request and response prefaces #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the naming conventions of the RFC.
ioquatix
force-pushed
the
breakout-read-prefaces
branch
from
f28c066
to
490f13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits off reading of the first line of both requests and responses into separate methods. It makes no functional changes.
The intent is to make it easier to inject added functionality after reading the first line (ie: preface) or before reading the headers, most likely via a monkeypatch.
Immediate use case: changing the IO stream timeout before and after reading the preface line.
Related to socketry/async-http#127.
Types of Changes
Contribution