Fix implementation of rack.hijack. (#10)

socketry · Dec 11, 2023 · ffb9c88 · ffb9c88
1 parent 3a9ff0e
commit ffb9c88
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/protocol/rack/adapter/generic.rb b/lib/protocol/rack/adapter/generic.rb
@@ -74,6 +74,7 @@ def unwrap_request(request, env)
 					end
 
 					if request.respond_to?(:hijack?) and request.hijack?
+						env[RACK_IS_HIJACK] = true
 						env[RACK_HIJACK] = proc{request.hijack!.io.dup}
 					end
 

diff --git a/lib/protocol/rack/adapter/rack2.rb b/lib/protocol/rack/adapter/rack2.rb
@@ -17,9 +17,6 @@ class Rack2	< Generic
 				RACK_MULTIPROCESS = 'rack.multiprocess'
 				RACK_RUN_ONCE = 'rack.run_once'
 
-				RACK_IS_HIJACK = 'rack.hijack?'
-				RACK_HIJACK = 'rack.hijack'
-
 				def self.wrap(app)
 					Rewindable.new(self.new(app))
 				end

diff --git a/lib/protocol/rack/constants.rb b/lib/protocol/rack/constants.rb
@@ -36,5 +36,9 @@ module CGI
 		RACK_URL_SCHEME = 'rack.url_scheme'
 		RACK_PROTOCOL = 'rack.protocol'
 		RACK_RESPONSE_FINISHED = 'rack.response_finished'
+
+		# Rack hijack support:
+		RACK_IS_HIJACK = 'rack.hijack?'
+		RACK_HIJACK = 'rack.hijack'
 	end
 end