[CSI] OFFLINE volume expansion support #353
Conversation
| @@ -21,7 +22,7 @@ metadata: | |||
| name: csi-pvc-opensdsplugin-block | |||
| spec: | |||
| accessModes: | |||
| - ReadWriteMany | |||
| - ReadWriteOnce | |||
There was a problem hiding this comment.
What is the reason for this change?
There was a problem hiding this comment.
This is an example deployment file and ReadWriteOnce is generally used accessMode. So updated the example file, no other reason for change
csi/plugins/block/node.go
Outdated
| //Output looks like : [4:0:0:1] disk IET VIRTUAL-DISK 0001 /dev/sdb | ||
| // Need to parse and get host identifier (4 in above case) | ||
| glog.V(5).Infof("end to node expand volume, lsscsi: %v", output) | ||
| hostId := strings.Split(output, " ")[0] |
There was a problem hiding this comment.
Was just thinking will this is be better:
i := strings.Index(output, "[")
fmt.Printf("%c", output[i+1])
Or else, simple regex
| glog.V(5).Infof("start to controller expand volume") | ||
| defer glog.V(5).Info("end to controller expand volume") | ||
|
|
||
| return nil, status.Error(codes.Unimplemented, "") |
There was a problem hiding this comment.
Any specific reason to keep this unimplemented?
|
|
||
| defer glog.V(5).Info("end to node expand volume") | ||
| return nil, status.Error(codes.Unimplemented, "") | ||
| } |
There was a problem hiding this comment.
Any specific reason to keep this unimplemented?
| }) | ||
|
|
||
| if err != nil { | ||
| msg := fmt.Sprintf("failed to extend volume: %v", err) |
There was a problem hiding this comment.
this is similar to error msg in line 241, probably we can re-prahse it "failed to get stable status after extendVolume . "
(Suggestion)
|
@sushanthakumar @kumarashit Can we merge this PR? |
What this PR does / why we need it:
This change addresses the offline volume expansion support from side
When the volume demand (pvc) is edited to request more volume csi containers will trigger csi block plugin to provision volume expansion.
Some key highlights
Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This PR addresses part(offline) of the issue: #209
Special notes for your reviewer:
Test steps:
Release note: