Compatible old ReportUtil usage and supply test cases #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 52
💛 - Coveralls |
added 2 commits
June 4, 2018 19:28
khotyn
requested changes
Jun 4, 2018
|
Please attach this PR to a milestone, and the PR description should be have more detail like this |
khotyn
requested changes
Jun 4, 2018
|
|
||
| ### Environment | ||
|
|
||
| - SOFA Lookout version: |
There was a problem hiding this comment.
DO NOT JUST COPY FROM OTHER PROJECT!
khotyn
requested changes
Jun 4, 2018
| @@ -0,0 +1,40 @@ | |||
| package com.alipay.sofa.common.utils; | |||
There was a problem hiding this comment.
What is the purpose of this test case? It seems that it is not related to this issue.
There was a problem hiding this comment.
#16 only litte cases and should provide more test cases after 。 PR additional remarks
There was a problem hiding this comment.
Please only do one thing in on PR next time.
guanchao-yang
changed the title
khotyn
requested changes
Jun 4, 2018
| * <p> | ||
| * Created by yangguanchao on 18/06/04. | ||
| */ | ||
| public class ReportUtil extends com.alipay.sofa.common.utils.ReportUtil{ |
There was a problem hiding this comment.
Add a Deprecated annotation here cause it is only for the compatible problem.
khotyn
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Before some alipay users use
ReportUtilwith the full packagecom.alipay.sofa.common.log.ReportUtilbut in this versionReportUtilhas been moved tocom.alipay.sofa.common.utils.ReportUtil. Consider many users has used, so we should be compatible with itModification
com.alipay.sofa.common.log.ReportUtilextendscom.alipay.sofa.common.utils.ReportUtilfor compatibleResult
Fixes
#14
#16 only litte cases and after should provide more test cases