chore: improve rpcresponseFactoryTest

sofastack · Sep 2, 2024 · 23f4b14 · 23f4b14
1 parent 494f868
commit 23f4b14
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/jraft-core/src/test/java/com/alipay/sofa/jraft/rpc/RpcResponseFactoryTest.java b/jraft-core/src/test/java/com/alipay/sofa/jraft/rpc/RpcResponseFactoryTest.java
@@ -26,6 +26,13 @@
 import static org.junit.Assert.assertEquals;
 
 public class RpcResponseFactoryTest {
+    @Test
+    public void testNewResponseWithNull() {
+        ErrorResponse response = (ErrorResponse) RpcFactoryHelper.responseFactory().newResponse(null, null);
+        assertEquals(response.getErrorCode(), 0);
+        assertEquals(response.getErrorMsg(), "OK");
+    }
+
     @Test
     public void testNewResponseFromStatus() {
         ErrorResponse response = (ErrorResponse) RpcFactoryHelper.responseFactory().newResponse(null, Status.OK());
@@ -42,13 +49,21 @@ public void testNewResponseWithErrorStatus() {
     }
 
     @Test
-    public void testNewResponseWithVaridicArgs() {
+    public void testNewResponseWithVaridicNumberArgs() {
         ErrorResponse response = (ErrorResponse) RpcFactoryHelper.responseFactory().newResponse(null, 300,
             "hello %s %d", "world", 99);
         assertEquals(response.getErrorCode(), 300);
         assertEquals(response.getErrorMsg(), "hello world 99");
     }
 
+    @Test
+    public void testNewResponseWithVaridicStringArgs() {
+        ErrorResponse response = (ErrorResponse) RpcFactoryHelper.responseFactory().newResponse(null, 300,
+            "hello %s %s", "world", "99");
+        assertEquals(response.getErrorCode(), 300);
+        assertEquals(response.getErrorMsg(), "hello world 99");
+    }
+
     @Test
     public void testNewResponseWithArgs() {
         ErrorResponse response = (ErrorResponse) RpcFactoryHelper.responseFactory().newResponse(null, 300,