fix: ws onDisconnect handler removed

softvisio-node · Sep 16, 2024 · a613ef3 · a613ef3
1 parent 0a3eb43
commit a613ef3
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/lib/http/server.js b/lib/http/server.js
@@ -246,7 +246,7 @@ export default class HttpServer {
         return this.#method( "trace", location, callback );
     }
 
-    ws ( location, { onUpgrade, onConnect, onDisconnect, createConnection, maxPayloadLength, idleTimeout, sendPingsAutomatically, compress, compression, maxBackpressure } = {} ) {
+    ws ( location, { onUpgrade, onConnect, createConnection, maxPayloadLength, idleTimeout, sendPingsAutomatically, compress, compression, maxBackpressure } = {} ) {
         maxPayloadLength ??= DEFAULT_WEBSOCKET_MAX_PAYLOAD_LENGTH;
 
         // seconds, 0 - don't disconnect on timeout
@@ -318,8 +318,6 @@ export default class HttpServer {
             const res = result( [ status, Buffer.from( statusText ).toString() ] );
 
             ws.connection._onDisconnect( res );
-
-            if ( onDisconnect ) onDisconnect( ws.connection, res );
         };
 
         // message