Skip to content

Commit

Permalink
Fix issue: QBO - Preferred exporter/Export date tab do not auto-close…
Browse files Browse the repository at this point in the history
… after value selected
  • Loading branch information
WojtekBoman committed Oct 25, 2024
1 parent 8cd6ade commit 072ea6a
Showing 2 changed files with 13 additions and 2 deletions.
13 changes: 12 additions & 1 deletion contributingGuides/NAVIGATION.md
Original file line number Diff line number Diff line change
@@ -342,4 +342,15 @@ Linked issue: https://github.com/Expensify/App/pull/44138
2. If there are no messages in the chat, send a message.
3. Press reply in thread.
4. Press the "From" link in the displayed header.
5. Verify if the link correctly redirects to the chat opened in the first step.
5. Verify if the link correctly redirects to the chat opened in the first step.

#### QBO - Preferred exporter/Export date tab do not auto-close after value selected

Linked issue: https://github.com/Expensify/App/pull/49539#issuecomment-2433342220

Precondition: Workspace with QBO integration connected.

1. Go to Workspace > Accounting.
2. Click on Export > Preferred exporter (or Export date).
3. Click on value.
4. Verify if the value chosen in the third step is selected and the app redirects to the Export page.
2 changes: 1 addition & 1 deletion src/libs/Navigation/Navigation.ts
Original file line number Diff line number Diff line change
@@ -218,7 +218,7 @@ function goUp(fallbackRoute: Route) {
return;
}

const distanceToPop = targetState.routes.length - indexOfFallbackRoute - 1;
const distanceToPop = targetState.routes.length - indexOfFallbackRoute;
navigationRef.current.dispatch({...StackActions.pop(distanceToPop), target: targetState.key});
}

0 comments on commit 072ea6a

Please sign in to comment.