Add JS editor to playground #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wkazmierczak
commented
Aug 20, 2024
•
wkazmierczak
commented
- Add JS editor to playground
- Make entered code runnable
wkazmierczak
force-pushed
the
@wkazmierczak/react-editor
branch
from
937264f
to
2a28b95
Compare
wkazmierczak
force-pushed
the
@wkazmierczak/react-editor
branch
from
2a28b95
to
2278ff1
Compare
wkazmierczak
force-pushed
the
@wkazmierczak/react-editor
branch
from
a70d5d4
to
fa9cf49
Compare
wkozyra95
reviewed
Aug 21, 2024
docs/src/reactEditor.d.ts
Outdated
docs/src/playgroundReactRunner.ts
Outdated
| /** | ||
| * from https://github.com/facebook/react/blob/d906de7f602df810c38aa622c83023228b047db6/scripts/babel/transform-prevent-infinite-loops.js | ||
| */ | ||
| // biome-ignore lint/suspicious/noExplicitAny: |
There was a problem hiding this comment.
Suggested change
| // biome-ignore lint/suspicious/noExplicitAny: |
docs/src/playgroundReactRunner.ts
Outdated
| }; | ||
| }; | ||
|
|
||
| export default async function playgroundReactRunner(code: string) { |
There was a problem hiding this comment.
name implies that this returns some statetfull runner, but If I understand correctly this is a single run
Suggested change
| export default async function playgroundReactRunner(code: string) { | |
| export default async function executeTypescriptCode(code: string) { |
docs/src/playgroundReactRunner.ts
Outdated
| import type TemplateGenerator from '@babel/template'; | ||
| import { tsCompilerOptions } from './monacoEditorConfig'; | ||
|
|
||
| function tsToJs(code: string): string { |
There was a problem hiding this comment.
maybe inline that, not sure if extracting this to function helps here
docs/src/pages/playground.tsx
Outdated
Comment on lines
75
to
83
| useEffect(() => { | ||
| const params = new URLSearchParams(window.location.search); | ||
| const codeEditorMode = params.get('mode'); | ||
| if (codeEditorMode === 'react') { | ||
| setShowReactEditor(true); | ||
| } else { | ||
| setShowReactEditor(false); | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| const params = new URLSearchParams(window.location.search); | |
| const codeEditorMode = params.get('mode'); | |
| if (codeEditorMode === 'react') { | |
| setShowReactEditor(true); | |
| } else { | |
| setShowReactEditor(false); | |
| } | |
| }, []); | |
| const showReactEditor = new URLSearchParams(window.location.search).get('mode') === 'react'; |
wouldn't this work?
There was a problem hiding this comment.
error while building, because of client-side only code, but i have refactor this useEffect to make it simpler
wkozyra95
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.