Add eslint rule @typescript-eslint/no-floating-promises in demos and docs directory
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkazmierczak
changed the title
no-floating-promises in docs and demos dirsdemos and docs directory
wkazmierczak
force-pushed
the
@wkazmierczak/add-eslint-rule-no-floating-promises-demos-docs
branch
from
1563059
to
852c932
Compare
wkazmierczak
force-pushed
the
@wkazmierczak/add-eslint-rule-no-floating-promises-demos-docs
branch
from
852c932
to
becd1cb
Compare
wkozyra95
reviewed
Sep 13, 2024
demos/utils/run.ts
Outdated
| @@ -20,7 +20,7 @@ export async function runCompositorExample( | |||
|
|
|||
| await fn(); | |||
| } catch (err) { | |||
| logError(err); | |||
| void logError(err); | |||
There was a problem hiding this comment.
Suggested change
| void logError(err); | |
| await logError(err); |
wkazmierczak
force-pushed
the
@wkazmierczak/add-eslint-rule-no-floating-promises-demos-docs
branch
from
3100769
to
8d343bc
Compare
wkozyra95
reviewed
Sep 16, 2024
demos/utils/gst.ts
Outdated
| @@ -31,7 +31,7 @@ export function gstStreamWebcam(ip: string, port: number, displayOutput: boolean | |||
|
|
|||
| function checkGstPlugins(plugins: string[]) { | |||
| plugins.forEach(plugin => { | |||
There was a problem hiding this comment.
this function is incorrect, exception will not be thrown in checkGstPlugins
convert it to regular for loop, or await Promise.all(plugins.map(plugin => ...))
wkazmierczak
force-pushed
the
@wkazmierczak/add-eslint-rule-no-floating-promises-demos-docs
branch
from
d9b62c7
to
7e73c56
Compare
wkozyra95
approved these changes
Sep 16, 2024
wkazmierczak
deleted the
@wkazmierczak/add-eslint-rule-no-floating-promises-demos-docs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.