-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESM + CJS support for live-compositor
and @live-compositor/core
#802
base: master
Are you sure you want to change the base?
Conversation
1cf896b
to
bb1dc6c
Compare
bb1dc6c
to
3c9fb1b
Compare
@@ -23,14 +23,5 @@ | |||
}, | |||
"peerDependencies": { | |||
"live-compositor": "^0.1.0" | |||
}, | |||
"nx": { | |||
"targets": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run npm run build
often in root and this was very anoying
@@ -16,6 +17,17 @@ | |||
"tsconfig.json" | |||
] | |||
}, | |||
"settings": { | |||
"import/parsers": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default eslint-plugin-import
can't detect correctly exports
section to detect esm, this seems to resolve the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
For node we usually want to support CJS modules, but for projects like vite ESM seems to be needed. This PR builds
live-compositor
and@live-compositor/core
packages to both esm and cjs