Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSR: unlock deposit integration #1822

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tomjohn1028
Copy link
Contributor

@tomjohn1028 tomjohn1028 commented Sep 13, 2023

  • Updates the VSR IDL to 0.2.5, which is built from this commit
  • Add support for the UnlockDeposit instruction

Questions/Concerns

  • Not all VSR instances will be upgraded to include this functionality. Should there be a VSR program ID check to validated?

In an ideal world, Realms uses on-chain IDLs and has a more flexible approach to adding proposals. I'm not sure where that is on the roadmap.

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 11:37pm

@asktree
Copy link
Collaborator

asktree commented Sep 14, 2023

Is there some way we can get the VSR version / fork using on-chain data? this stuff shouldnt show up if the version of VSR doesn't support it.

To be clear, you are running a VSR fork right? this isn't some new feature in mainline VSR?

@tomjohn1028
Copy link
Contributor Author

Is there some way we can get the VSR version / fork using on-chain data? this stuff shouldnt show up if the version of VSR doesn't support it.

The most fool proof way would be a hard coded list of program ID's that feature gate this instruction.

To be clear, you are running a VSR fork right? this isn't some new feature in mainline VSR?

Correct. Discussion on whether these features getting added to main VSR is TBD. So for now it's best to assume it will not make it into the main VSR repo.

@SebastianBor
Copy link
Collaborator

Correct. Discussion on whether these features getting added to main VSR is TBD. So for now it's best to assume it will not make it into the main VSR repo.

Do you have more details what the new features are about please?

@tomjohn1028
Copy link
Contributor Author

@SebastianBor added more details to the comment in this PR mithraiclabs/voter-stake-registry#1 (comment)

@vercel
Copy link

vercel bot commented Sep 18, 2023

@tomjohn1028 is attempting to deploy a commit to the blockworks-foundation Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants