Show default favicon if dao doesnt have a custom favicon #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const { result: faviconExists } = useAsync( | ||
| async () => | ||
| faviconUrl | ||
| ? fetch(faviconUrl) |
Check failure
Code scanning / CodeQL
Server-side request forgery
There was a problem hiding this comment.
I made a post in the Next JS discord about this: https://discord.com/channels/752553802359505017/1158876987130122260/1158876987130122260
There was a problem hiding this comment.
(dismissed alert, it is definitely a false positive)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would try to use a favicon for a dao, even if they didnt have one, resulting in a missing favicon and a 404 in the console.
Now, we check if it exists first. You might think NextJs has a way to do this without doing a fetch, but it doesn't seem to vercel/next.js#10172