Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DepositTokensButton.tsx #1880

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update DepositTokensButton.tsx #1880

merged 1 commit into from
Oct 16, 2023

Conversation

kirksgithub
Copy link
Contributor

Fixed Disabled state on button

Fixed Disabled state on button
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 8:56pm

@kirksgithub
Copy link
Contributor Author

The Deposit button automatically allowed the Max amount to be deposited, nevertheless this changed causing issues for our DAO members, in specific we identified the following:

Deposit amount should be defaulted to the Max amount
Deposit amount when typing is no longer available, so for larger numbers the total available, the user can enter an amount which is not their actual max amount.
To improve this slow and confusing experience, the popup should be easier to navigate as specified above.

We also recommend that in the future this button is pushed as an advanced button either in the "My Governance View" or as a dropdown button as an additional option

The fixes here will be to improve the UI/UX and allow a default Max to be set along with any helper buttons to ease setting the Max deposit amount

@kirksgithub
Copy link
Contributor Author

This update fixes UI/UX issues with depositing tokens to a governance, although this button should have been pushed as an advanced menu option/deposit option in the "My Governance Power" and not exposed for regular users who would like to quickly deposit and participate in Governance:

Added Max helper button amount
Set default input to have the max amount (as it is typically intended by the user to deposit the entire amount to governance)
Disable confirm button if amount <= 0 and amount > max
Label prop was moved outside the input field to support a Max button
This should improve the experience significantly so users are not guessing the amount they have as a balance while in this prompt

(sorry for the second commit)

@asktree asktree merged commit c3eca0d into solana-labs:main Oct 16, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants