stake-pool: Downgrade dependencies for fixed release #7509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The current spl-stake-pool crate doesn't always work due to its dependency on spl-math which still uses the v1 Solana crates. #### Summary of changes Since the spl-math dependency wasn't actually needed, it was removed in solana-labs#7421. So just to get a new patch release out, downgrade the local dependencies. This will fail CI, but after it lands we can tag the release, and revert this PR.
joncinque
added a commit
to joncinque/solana-program-library
that referenced
this pull request
Nov 20, 2024
…labs#7509)" This reverts commit d4c250f.
joncinque
added a commit
that referenced
this pull request
Nov 20, 2024
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current spl-stake-pool crate doesn't always work due to its dependency on spl-math which still uses the v1 Solana crates.
Summary of changes
Since the spl-math dependency wasn't actually needed, it was removed in #7421. So just to get a new patch release out, downgrade the local dependencies.
This will fail CI, but after it lands we can tag the release, and revert this PR.
cc @billythedummy