feat: Agave v2 RPC: replace getConfirmedTransaction with getTransaction
#3418
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @buffalojoec and the rest of your teammates on |
This was referenced Oct 23, 2024
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
2fe2282
to
6acd1dc
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
950dba5
to
ee67085
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
6acd1dc
to
22a65a5
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
ee67085
to
f96e4d2
Compare
lorisleiva
approved these changes
Oct 29, 2024
mcintyre94
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the upcoming upgrade from 1.18 to 2.0 on Solana mainnet-beta, deprecated RPC methods have been removed, therefore they will no longer be available through Web3.js client requests.
The Agave 2.0 Migration Guide lists semi-equivalent RPC method counterparts for each of the removed methods.
Summary of Changes
Replace
getConfirmedTransactionwithgetTransaction. This method was already requiring a confirmation level ofconfirmedorfinalized, so the behavior should be unchanged.