CLI BIP32 prep: KeypairUrl refactor
#16592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16592 +/- ##
=======================================
Coverage 79.9% 79.9%
=======================================
Files 414 414
Lines 112270 112300 +30
=======================================
+ Hits 89789 89818 +29
- Misses 22481 22482 +1 |
This was referenced Apr 16, 2021
mergify bot
added a commit
that referenced
this pull request
Apr 16, 2021
* clap-utils: Rename KeypairUrl to SignerSource (cherry picked from commit 09dcc9e) * clap-utils: Reduce SignerSource's visibility (cherry picked from commit c5ab3ba) * clap-utils: Use `uriparse` crate to parse `SignerSource` (cherry picked from commit 5d1ef5d) * clap-utils: Add explicit schemes for `ask` and `file` `SignerSource`s (cherry picked from commit 6444f0e) Co-authored-by: Trent Nelson <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Apr 16, 2021
* clap-utils: Rename KeypairUrl to SignerSource (cherry picked from commit 09dcc9e) * clap-utils: Reduce SignerSource's visibility (cherry picked from commit c5ab3ba) * clap-utils: Use `uriparse` crate to parse `SignerSource` (cherry picked from commit 5d1ef5d) # Conflicts: # Cargo.lock # clap-utils/Cargo.toml * clap-utils: Add explicit schemes for `ask` and `file` `SignerSource`s (cherry picked from commit 6444f0e) Co-authored-by: Trent Nelson <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Signer source path parsing is hand coded and doesn't lend itself to the extension necessary to specify BIP32 derivation paths
Summary of Changes
Rename
Refactor to use an RPC compliant URI parsing crate
Adds explicit schemes for
fileandaskmethodsToward #5246