Make prepare_simulation_batch() more usable

[ryoqun]

Problem

• prepare_simulation_batch requires .clone()-ing.
• its name isn't generic to be used by others (ref: Add new execution code-path for unified scheduler #31239 )

Summary of Changes

• make it take refs; seems there's no practical merit of transferring the ownership into TransactionBatch in the hope of avoiding some internal cloning... Originally, i thought generic approach made sense: Add new execution code-path for unified scheduler #31239 (comment)
  • less is more. :)
• and rename it.

Fixes #

[codecov]

Codecov Report

Merging #32304 (3287105) into master (4cfdb37) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #32304   +/-   ##
=======================================
  Coverage    82.0%    82.0%           
=======================================
  Files         773      773           
  Lines      209616   209619    +3     
=======================================
+ Hits       172038   172041    +3     
  Misses      37578    37578           

[apfitzge]

Change itself looks good. Slight hesitation on the naming, as there's no indication (just from the name) that this is for a single transaction "batch".

From the other fns in this area I'd assume I pass it a transactions: &'b [SanitizedTransaction],

wdyt?

[ryoqun]

Slight hesitation on the naming, as there's no indication (just from the name) that this is for a single transaction "batch".

From the other fns in this area I'd assume I pass it a transactions: &'b [SanitizedTransaction],

nice suggestion: fc8edca

[apfitzge]

lgtm - though you might want to wait for @ilya-bobyr's review; I saw you explicitly requested his review and I just happen to notice the PR.

[ilya-bobyr]

Somehow, this PR was not in my inbox %)
I must have opened it and then closed the tab by accident.
Looks good to me.

[ilya-bobyr]

minor

I think in most cases, elements are imported, up to a certain meaningful parent, rather than referenced with the full path. Even for std:

use std::slice;

And then

Suggested change

	Cow::Borrowed(std::slice::from_ref(transaction)),
	Cow::Borrowed(slice::from_ref(transaction)),

[ryoqun]

nice! done 3287105