New exec code path rebased #33070
Closed
New exec code path rebased #33070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #33070 +/- ##
=========================================
- Coverage 81.5% 81.3% -0.3%
=========================================
Files 834 835 +1
Lines 224876 226614 +1738
=========================================
+ Hits 183496 184448 +952
- Misses 41380 42166 +786 |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
This was referenced Oct 5, 2023
This was referenced Oct 26, 2023
ryoqun
force-pushed
the
new-exec-code-path-rebased
branch
from
5089205
to
322154a
Compare
This was referenced Oct 29, 2023
ryoqun
commented
Nov 3, 2023
scheduler-pool/src/lib.rs
Outdated
| fn pool(&self) -> InstalledSchedulerPoolArc<SEA> { | ||
| self.pool.clone() | ||
| fn return_to_pool(self: Box<Self>) { | ||
| self.pool.clone().return_scheduler(self) |
There was a problem hiding this comment.
oh, the .clone() can be removed, btw... ;)
There was a problem hiding this comment.
well, never mind. i can't. borrow checker would complain...
ryoqun
commented
Nov 3, 2023
scheduler-pool/src/lib.rs
Outdated
Comment on lines
114
to
121
| pub fn return_scheduler(&self, scheduler: Box<dyn InstalledScheduler<SEA>>) { | ||
| assert!(scheduler.context().is_none()); | ||
|
|
||
| self.schedulers | ||
| .lock() | ||
| .expect("not poisoned") | ||
| .push(scheduler); | ||
| } |
github-actions
bot
added
stale
ryoqun
commented
Jan 11, 2024
runtime/src/bank.rs
Outdated
Comment on lines
5215
to
5265
| self.loaded_programs_cache | ||
| .write() | ||
| .unwrap() |
ryoqun
commented
Feb 2, 2024
Comment on lines
+246
to
+251
| // this cuts circular references of BankForks... | ||
| root_bank | ||
| .loaded_programs_cache | ||
| .write() | ||
| .unwrap() | ||
| .unset_fork_graph(); |
There was a problem hiding this comment.
ryoqun
commented
Feb 26, 2024
|
This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is yet another pr for unified scheduler (prev: #31239)
todo
--unified-scheduler-handler-threads=N--unified-scheduler-individual-transaction-timings?