Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses struct instead of tuple for Merkle shreds variant #35303

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

behzadnouri
Copy link
Contributor

Problem

Working towards adding a new Merkle shred variant with retransmitter's signature.

Summary of Changes

The commit uses struct instead of tuple for Merkle shreds variant.
This is part of #35293 factored out into its own commit.

Working towards adding a new Merkle shred variant with retransmitter's
signature.
Copy link
Contributor

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behzadnouri behzadnouri merged commit c8ee4f5 into solana-labs:master Feb 26, 2024
35 checks passed
@behzadnouri behzadnouri deleted the merkle-variant-struct branch February 26, 2024 15:58
@behzadnouri behzadnouri added the v1.18 PRs that should be backported to v1.18 label Feb 26, 2024
Copy link
Contributor

mergify bot commented Feb 26, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Feb 26, 2024
Working towards adding a new Merkle shred variant with retransmitter's
signature, the commit uses struct instead of tuple to describe Merkle shred
variant.

(cherry picked from commit c8ee4f5)
mergify bot added a commit that referenced this pull request Feb 26, 2024
…rt of #35303) (#35321)

uses struct instead of tuple for Merkle shreds variant (#35303)

Working towards adding a new Merkle shred variant with retransmitter's
signature, the commit uses struct instead of tuple to describe Merkle shred
variant.

(cherry picked from commit c8ee4f5)

Co-authored-by: behzad nouri <[email protected]>
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Feb 27, 2024
…5303)

Working towards adding a new Merkle shred variant with retransmitter's
signature, the commit uses struct instead of tuple to describe Merkle shred
variant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.18 PRs that should be backported to v1.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants