Update histograms code, move AO metrics exporter to main package #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheempz
reviewed
Oct 7, 2024
| const scopeTags = this.#scopeTags(scopeMetric.scope) | ||
|
|
||
| for (const metric of scopeMetric.metrics) { | ||
| const name = `trace.node.${metric.descriptor.name}` |
There was a problem hiding this comment.
This means OTel-originated metrics that get exported via apm-proto to AO will all be prefixed with trace.node.* (similar to runtime metrics)?
There was a problem hiding this comment.
Yep ! That's the standard they've been following
| const [tags, tagCount] = this.#oboeTags({ | ||
| ...scopeTags, | ||
| ...descriptorTags, | ||
| ...dataPointTags, |
There was a problem hiding this comment.
Does this mean all the above are set as the AO metric tags? Not sure what's a typical number of OTel metrics attrs to expect, but out of paranoia would it be easy to cap the max number of tags to 50 (inspired by https://github.com/solarwinds-cloud/trace/blob/master/docs/specs/custom-metrics.md) just to not rock the AO boat too much.
There was a problem hiding this comment.
Good point, I added an upper limit.
cheempz
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This histogram code is ported from ingestion, the exporter code is just copied from the existing one.