Remove last dependencies on SDK package, improve version detection #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheempz
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Thanks @raphael-theriault-swi please see my comments. One other question i'll ping you tomorrow on is regarding the HostID and __Init message when in OTLP mode.
| @@ -14,363 +14,296 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| */ | |||
There was a problem hiding this comment.
Wow, the big payoff--just skimmed this file but seeing what you did to get waitUntilReady working for this OTLP/AO switch gave me hint of the effort that went into the rewrite, kudos!
|
For the |
cheempz
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
LGTM, thanks for the explanation and revisits @raphael-theriault-swi! We'll tackle the HostID item as a follow on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big change since all references to the old config types had to be removed. Now everything is self contained in the
solarwinds-apmpackage. What remains after this is deleting the SDK package and any logic to target CommonJS.