NH-85973 NH-89212 instrument function handler dependencies #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheempz
changed the title
cheempz
commented
Aug 23, 2024
There was a problem hiding this comment.
Added some thoughts @xuan-cao-swi. And i see what you meant with ugly code to achieve this ;)... having to parse through the function code for require definitely isn't great but i also can't see a way around this for now.
The main thing i'm concerned with is that the extra preload and bootstrap logic don't introduce additional risk of function init failures (aka lambda crash) and startup overhead.
Co-authored-by: Lin Lin <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rescue can prevent the crash if certain library is not present in user's layers |
cheempz
commented
Aug 26, 2024
cheempz
commented
Aug 26, 2024
cheempz
commented
Aug 26, 2024
cheempz
commented
Aug 26, 2024
Co-authored-by: Lin Lin <[email protected]>
Co-authored-by: Lin Lin <[email protected]>
tammy-baylis-swi
approved these changes
Aug 27, 2024
molafson
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change, solarwinds_apm is loaded before the original handler, which means function handler dependencies are never instrumented because they are loaded too late (after OTel bootstraps the instrumentations).
Additionally, we found an AWS SDK client initialized outside the function handler was not instrumented even if solarwinds_apm is loaded after function code--this is due to the way AWS SDK instruments during client initialization rather than prepending.
The solution is to preload function's dependencies and explicitly bootstrap instrumentation, before loading solarwinds_apm.
Test (if applicable)
Manual testing with RC layer.