-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-89340: add ci/cd for reverse lab scan #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, one idea from me you can take or leave.
.github/workflows/ci-reverse-lab.yml
Outdated
rl-scan \ | ||
--rl-portal-server solarwinds \ | ||
--rl-portal-org SolarWinds \ | ||
--rl-portal-group "SaaS - Agents- SWO" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the correct group name.
No way, the correct portal group is double spaced.
I was trying all day last week with SaaS - Agents- SWO
and got
Started: Scanning version
Info: Not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel your pain 😁
Co-authored-by: Tammy Baylis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI. Actually there is a github action https://github.com/reversinglabs/gh-action-rl-scanner-cloud-only that does similar thing as your docker run command. Either take or leave my idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Enable the ci/cd for reverse lab. Check the reports, and if there is non-pass status, treat it as failed action run
Test (if applicable)