Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-89340: add ci/cd for reverse lab scan #146

Merged
merged 6 commits into from
Aug 28, 2024
Merged

NH-89340: add ci/cd for reverse lab scan #146

merged 6 commits into from
Aug 28, 2024

Conversation

xuan-cao-swi
Copy link
Contributor

Description

Enable the ci/cd for reverse lab. Check the reports, and if there is non-pass status, treat it as failed action run

Test (if applicable)

@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner August 26, 2024 14:15
@xuan-cao-swi xuan-cao-swi changed the title NH-89340 NH-89340: add ci/cd for reverse lab scan Aug 26, 2024
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one idea from me you can take or leave.

rl-scan \
--rl-portal-server solarwinds \
--rl-portal-org SolarWinds \
--rl-portal-group "SaaS - Agents- SWO" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correct group name.

No way, the correct portal group is double spaced.
I was trying all day last week with SaaS - Agents- SWO and got

Started: Scanning version
Info: Not found.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel your pain 😁

jerrytfleung
jerrytfleung previously approved these changes Aug 27, 2024
Copy link

@jerrytfleung jerrytfleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerrytfleung
Copy link

LGTM

FYI. Actually there is a github action https://github.com/reversinglabs/gh-action-rl-scanner-cloud-only that does similar thing as your docker run command. Either take or leave my idea.

Copy link

@jerrytfleung jerrytfleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuan-cao-swi xuan-cao-swi merged commit 05b0444 into main Aug 28, 2024
14 checks passed
@xuan-cao-swi xuan-cao-swi deleted the NH-89340 branch August 28, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants