Draft: eMode draft impl (WIP) #26
Conversation
|
|
||
| borrow.market_value = market_value; | ||
| unweighted_borrowed_value_usd = add(unweighted_borrowed_value_usd, market_value); | ||
|
|
There was a problem hiding this comment.
undo everything below here in this fn. this is purely formatting change, right?
There was a problem hiding this comment.
Removed the formatting stuff
| open_ltv_pct: u8, | ||
| close_ltv_pct: u8, | ||
| ) { | ||
| let has_emode_field = bag::contains(&reserve_config.additional_fields, EModeKey {}); |
…ccount for emode - Public function to toggle emode for a given obligation
contracts/sources/obligation.move
Outdated
| assert!(vector::length(&obligation.borrows) <= MAX_BORROWS, ETooManyBorrows); | ||
| let is_emode = is_emode(obligation); | ||
|
|
||
| if (is_emode) { |
There was a problem hiding this comment.
i would do this check after the borrow is processed. similar to the isolated check
if (isolated(config(reserve)) || obligation.borrowing_isolated_asset) {. the logic is simpler that way.
same comment for deposit
contracts/sources/obligation.move
Outdated
| @@ -392,6 +503,12 @@ module suilend::obligation { | |||
|
|
|||
| borrow.borrowed_amount = sub(borrow.borrowed_amount, repay_amount); | |||
|
|
|||
| let borrow_weight = if (is_emode) { | |||
There was a problem hiding this comment.
no need for is_emode flag if the value is only used once
| @@ -379,6 +379,30 @@ module suilend::lending_market { | |||
| obligation::zero_out_rewards_if_looped(obligation, &mut lending_market.reserves, clock); | |||
| coin::from_balance(receive_balance, ctx) | |||
| } | |||
|
|
|||
| /// Set emode for obligation - T is the deposit coin type | |||
| public fun set_emode<P>( | |||
There was a problem hiding this comment.
i don't think we need to know the reserve array indicies to set emode?
There was a problem hiding this comment.
an obligation is a valid emode obligation if it has 1 or less deposits and 1 or less borrows
There was a problem hiding this comment.
When we call deposit for an emode obligation we need to be able to know what the corresponding borrow reserve is in order to get the respective emode ltv
| @@ -167,6 +184,45 @@ module suilend::obligation { | |||
| } | |||
| } | |||
|
|
|||
| public(friend) fun set_emode<P>( | |||
| obligation: &mut Obligation<P>, | |||
| deposit_reserve: &Reserve<P>, | |||
There was a problem hiding this comment.
similarly to my comment in lending market, not sure why we need to know the deposit and borrow reserve
There was a problem hiding this comment.
Same response as above:
When we call deposit for an emode obligation we need to be able to know what the corresponding borrow reserve is in order to get the respective emode ltv
- Increase test coverage
| @@ -819,6 +843,22 @@ module suilend::lending_market { | |||
| reserve::update_reserve_config<P>(reserve, config); | |||
| } | |||
|
|
|||
| public fun set_emode_for_pair<P, T>( | |||
There was a problem hiding this comment.
i think it makes sense to get the type argument for the pair reserve as well, just as a sanity check.
|
|
||
| // The obligation must ONLY have one deposit and one borrow, and | ||
| // they both must match the emod ones | ||
| if (vector::length(&obligation.borrows) == 1) { |
There was a problem hiding this comment.
hmm. so the obligation has to have a deposit and borrow before activating e-mode? This feels a bit restrictive. IMO all the states below are valid:
- has no deposit, no borrow
- has deposit, no borrow
- has deposit, borrow
| @@ -319,6 +399,14 @@ module suilend::obligation { | |||
| deposit.deposited_ctoken_amount, | |||
| clock | |||
| ); | |||
|
|
|||
| if (is_emode) { | |||
| assert!(vector::length(&obligation.deposits) == 1, EIsolatedAssetViolation); | |||
There was a problem hiding this comment.
IsolatedAsset refers to something else, so i would use EInvalidEModeDeposit
| @@ -366,9 +461,16 @@ module suilend::obligation { | |||
|
|
|||
| assert!(is_healthy(obligation), EObligationIsNotHealthy); | |||
|
|
|||
| if (isolated(config(reserve)) || obligation.borrowing_isolated_asset) { | |||
| if (isolated(config(reserve)) || obligation.borrowing_isolated_asset || is_emode) { | |||
There was a problem hiding this comment.
nit: eh, lets just explicitly check num_borrows == 1 in the is_emode branch below
| @@ -379,6 +481,12 @@ module suilend::obligation { | |||
| clock: &Clock, | |||
| max_repay_amount: Decimal, | |||
| ): Decimal { | |||
| let borrow_weight = if (is_emode(obligation)) { | |||
There was a problem hiding this comment.
nit: move this expression closer to where the value is used, ie right before
if (le(interest_diff, repay_amount)) {
No description provided.