Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ldn-channel-2023 ED #147

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Add ldn-channel-2023 ED #147

merged 5 commits into from
Feb 3, 2023

Conversation

csarven
Copy link
Member

@csarven csarven commented Jan 12, 2023

This ED defines the LDNChannel2023 Notification Channel Type. This specification deprecates LinkedDataNotifications Subscription 2021.


Preview

@csarven
Copy link
Member Author

csarven commented Jan 16, 2023

  • Updated to follow the structure of Solid Notifications Protocol Version 0.2.0.
  • Introduced activityType as a feature to indicate the desired notification activity type, e.g., messages can be about particular activities, like when a resource is created or added to a container (a general requirement as suggested in Activity Subscriptions notifications-panel#1 (comment) ). I suggest making this a core feature of Solid Notifications Protocol.
  • Subscription Server and Notification Receiver is a specialisation of LDN Receiver. (See also https://www.w3.org/TR/ldn/#subscribing-to-notifications ).
  • Subscription resource and sendTo act like LDN inboxes. (See also Subscription service as a container #36 )
  • POSTing to it returns a 201 to a resource where it can be modified or deleted (aka unsubscribing). Whether DELETE is used to unsubscribe or POSTing again to the created resource indicating the changes to be determined. (See also Define unsubscribing #145 ).
  • Introduced receiver (analogous to sender) to identify the party (Notification Receiver) that controls the sendTo resource.
  • Described an outline for exchanging public keys and towards signing messages. (Copied to issue Authentication: exchanging public keys, signing messages #148 ).

@csarven csarven self-assigned this Jan 16, 2023
@acoburn
Copy link
Member

acoburn commented Jan 31, 2023

Introduced activityType as a feature to indicate the desired notification activity type, e.g., messages can be about particular activities, like when a resource is created or added to a container (a general requirement as suggested in solid/notifications-panel#1 (comment) ). I suggest making this a core feature of Solid Notifications Protocol.
Subscription Server and Notification Receiver is a specialisation of LDN Receiver. (See also https://www.w3.org/TR/ldn/#subscribing-to-notifications ).

I really like this idea, and I also think this should be considered for the core notifications protocol. I would suggest generalizing this a bit further, calling it, perhaps, filter, which would accept an object. For example:

{
    "filter": {
       "type": "Add"
    }
}

This would allow implementations (that support the feature) to have a much more generalized filtering mechanism.

To continue this example, one could add an actor property in the filter to accept only notifications from a particular agent. Other properties (e.g. tag) could be added to this, as needed. It could be a very extensible mechanism.

@csarven
Copy link
Member Author

csarven commented Feb 3, 2023

@csarven csarven merged commit 5beaec3 into main Feb 3, 2023
@csarven csarven deleted the ldn-channel-2023 branch February 3, 2023 15:21
@csarven csarven mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants