Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update env.d.ts #1621

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update env.d.ts #1621

wants to merge 2 commits into from

Conversation

huseeiin
Copy link
Contributor

@huseeiin huseeiin commented Sep 5, 2024

set START_SSR, START_ISLANDS, START_DEV_OVERLAY to boolean to match runtime
those values were set to string in TS but are booleans in runtime.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

set START_SSR, START_ISLANDS, START_DEV_OVERLAY to boolean to match runtime
Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: 59e2e85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants