add type for component #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-es
commented
Aug 31, 2021
src/index.d.ts
Outdated
Comment on lines
60
to
83
| args_0: | ||
| | string | ||
| | TemplateStringsArray | ||
| | CSSAttribute | ||
| | (( | ||
| props: P & { | ||
| theme?: any; | ||
| as?: string | number | symbol | undefined; | ||
| className?: any; | ||
| children?: any; | ||
| } | ||
| ) => string | CSSAttribute), | ||
| ...args_1: ( | ||
| | string | ||
| | number | ||
| | (( | ||
| props: P & { | ||
| theme?: any; | ||
| as?: string | number | symbol | undefined; | ||
| className?: any; | ||
| children?: any; | ||
| } | ||
| ) => string | number | CSSAttribute | undefined) | ||
| )[] |
There was a problem hiding this comment.
The types of the arguments are exactly the same as above.
Should I create new types and replace them?
There was a problem hiding this comment.
Yeah that's probably better. I very hastily ported these because Goobers types didn't play nice with ours but it was mostly copy and paste. I appreciate you taking the time to clean this up.
jay-es
commented
Sep 1, 2021
Comment on lines
+33
to
+34
| props: P & | ||
| T & { |
There was a problem hiding this comment.
T & P
added component's props to use them in the styling function without specifying the type.
jay-es
commented
Sep 1, 2021
| export declare function styled<T extends keyof JSX.IntrinsicElements>( | ||
| tag: T | ((props: JSX.IntrinsicElements[T]) => JSX.Element) | ||
| ): <P>( | ||
| type Tagged<T> = <P>( |
There was a problem hiding this comment.
return type of the styled function
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a type of
styled()to accept Components.ref #2 (comment)