Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all templates #140

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Jan 19, 2024

This repo hasn't had a commit in 7 months, so this PR updates all dependencies in the templates in this repo to their latest versions. This finally moves all templates to vite 5, and I've tested that they all work, due to the latest version of vite-plugin-solid.

Solid-Router example

Only template that I unfortunately didn't manage to fully update is ts-router, which is still on v0.8, where the latest router (v0.10 might require a bit of refactoring - assistance very welcome)

Vitest examples

Partially closes:

Fully closes:

I found that vitest, in contrast to uvu and jest, does require a

wrapping the , in order to be able to query the child elements. That is why that was broken. There is an open issue here (solidjs/solid-testing-library#53)

Also obsoletes all the dependabot issue:

@birkskyum
Copy link
Contributor Author

cc @davedbase , @atk , since the templates now are in use again, would you be able to have a look at this?

@ryansolid
Copy link
Member

Thanks.

@ryansolid ryansolid merged commit 16f750b into solidjs:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants