Allow to use the express checkout with a Solidus APIs application #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vassalloandrea
force-pushed
the
vassalloandrea/allow-express-checkout-solidus-apis
branch
from
74b87e4 to
9d3132c
Compare
vassalloandrea
requested review from
ChristianRimondi,
garciajordy and
mtylty
vassalloandrea
force-pushed
the
vassalloandrea/allow-express-checkout-solidus-apis
branch
from
9d3132c to
d37b7bd
Compare
|
@ChristianRimondi do you have any ideas for the coverage? It seems that a spec is missing but I tested the missing line 🤔 |
Change the express callback parent class based on the extension setting. This is needed adding the ability to use the express checkout callback with the JWT token.
Allow to respond with the solidus order on the express checkout complete action if the solidus_api are enabled. This is needed since the express callbacks controller create action updates the Solidus order information and those information could be useful to update the custom frontend without making another API call to Solidus.
vassalloandrea
force-pushed
the
vassalloandrea/allow-express-checkout-solidus-apis
branch
from
839a062 to
e5cab05
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
solidus_apiconfiguration is enabled we should return the order information back to the FE since we update it when the express checkoutonCompletecallback is triggered by Afterpay.