Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Zones and Endpoints Config #58

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

hefan
Copy link
Contributor

@hefan hefan commented Jul 17, 2023

like discussed in #57

@kennyadsl
Copy link
Member

kennyadsl commented Jul 18, 2023

Merging, the CI failures are not related.

FYI: with @vassalloandrea we tried to investigate the difference between country and zone in the Klarna context and we think there's some changes to do on the extension:

We will work on this in the next days, but please let me know if this makes sense for you as well @hefan. 🙏

@kennyadsl kennyadsl merged commit 73838a8 into solidusio-contrib:master Jul 18, 2023
@hefan
Copy link
Contributor Author

hefan commented Jul 18, 2023

yes, this seems reasonable. I guess the country preference is used only for the backend validation test?

Because at the storefronts payment screen there already appears a message if the country of the buyer address is not available at klarna. i guess there will be constraints regarding the Orders currency/country combination as well.

Here is the list of available countries, locales, and currencies at klarna.
https://docs.klarna.com/klarna-payments/in-depth-knowledge/puchase-countries-currencies-locales/

@kennyadsl
Copy link
Member

It seems like at the moment the country is used as a fallback in case there's no s billing or shipping address, when we serialize the order to send to Klarna. I think that's how Klarna understands which payment methods to display.

@hefan
Copy link
Contributor Author

hefan commented Jul 18, 2023

ok. so this means it is reasonable to leave the country as a preference, maybe slightly rename it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants